On Mar 9, 2018, at 10:35, Art Dev <8artdev@gmail.com> wrote:
I i want to create small PR, in which branch i had to create it, in master or any ?
2018-03-09 20:12 GMT+02:00 Art Dev <8artdev@gmail.com>:
Yes it works
2018-03-09 19:40 GMT+02:00 Bryan Van de ven <bryan@bokeh.org>:
Actually if you just want to contribute a small PR, the example works with both versions with this small change to create a new IOLoop explicitly in the thread worker:
diff --git a/examples/howto/server_embed/flask_embed.py b/examples/howto/server_embed/flask_embed.py
index 8322409e6..286868dac 100644
--- a/examples/howto/server_embed/flask_embed.py
+++ b/examples/howto/server_embed/flask_embed.py
@@ -1,4 +1,5 @@
from flask import Flask, render_template
+from tornado.ioloop import IOLoop
from bokeh.embed import server_document
from bokeh.layouts import column
@@ -41,7 +42,8 @@ def bkapp_page():
def bk_worker():
# Can't pass num_procs > 1 in this configuration. If you need to run multiple
# processes, see e.g. flask_gunicorn_embed.py
- server = Server({'/bkapp': modify_doc}, allow_websocket_origin=["localhost:8000"])
+ io_loop = IOLoop()
+ server = Server({'/bkapp': modify_doc}, io_loop=io_loop, allow_websocket_origin=["localhost:8000"])
server.start()
server.io_loop.start()
> On Mar 9, 2018, at 09:27, Art Dev <8artdev@gmail.com> wrote:
>
> in py python 3.6.4 bokeh=0.12.14 and tornado=5.0 not works, works with tornado 4.5.3
>
> 2018-03-09 18:44 GMT+02:00 Bryan Van de ven <bryan@bokeh.org>:
> Hi,
>
> As of this PR:
>
> Tornado 5 Compatibility by bryevdv · Pull Request #7329 · bokeh/bokeh · GitHub
>
> which was merged for 0.12.14, Bokeh is now compatible with the changes in Tornado 5.
>
> Thanks,
>
> Bryan
>
> > On Mar 9, 2018, at 07:50, Art Dev <8artdev@gmail.com> wrote:
> >
> > I have linux python 3.6
> >
> > 2018-03-09 17:36 GMT+02:00 Art Dev <8artdev@gmail.com>:
> > Yes i had same error in new tornado 5.0 v in python3
> > try
> > pip install --pre tornado==4.5.3
> >
> > It must to fix this error.
> >
> > 2018-03-09 15:08 GMT+02:00 Artur Scholz <artur.scholz.79@gmail.com>:
> > Yes, I can confirm that with Python2.7 it is working. However, Python3 (3.5.2 to be exact) is not working and gives this thread error, on Linux.
> > Can you reproduce this with Python3?
> >
> > On Thu, Mar 8, 2018 at 12:18 PM, Art Dev <8artdev@gmail.com> wrote:
> > I am using python2.7 and all is run and available on localhost:8000
> >
> > 2018-03-08 11:24 GMT+02:00 Artur Scholz <artur.scholz.79@gmail.com>:
> > Running the development server with 'python flask_embed.py'
> >
> > On Thu, Mar 8, 2018 at 9:45 AM, Art Dev <8artdev@gmail.com> wrote:
> > How do you run your server ?
> >
> > 2018-03-07 23:20 GMT+02:00 Artur Scholz <artur.scholz.79@gmail.com>:
> > Running the flask_embed example (https://github.com/bokeh/bokeh/blob/0.12.14/examples/howto/server_embed/flask_embed.py\) produces the following error:
> >
> > ...loop = asyncio.get_event_loop()
> > File "/usr/lib/python3.5/asyncio/events.py", line 632, in get_event_loop
> > return get_event_loop_policy().get_event_loop()
> > File "/usr/lib/python3.5/asyncio/events.py", line 578, in get_event_loop
> > % threading.current_thread().name)
> > RuntimeError: There is no current event loop in thread 'Thread-1'.
> >
> > Environment: Ubuntu 16.10, Python 3.5.2, Bokeh 0.12.14, Flask 0.12.2
> > (Works on Windows though)
> >
> > --
> > You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to bokeh+unsubscribe@continuum.io.
> > To post to this group, send email to bokeh@continuum.io.
> > To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/a1aec075-1c64-4fcb-bd4c-52dafceaffa6%40continuum.io\.
> > For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
> >
> >
> > --
> > You received this message because you are subscribed to a topic in the Google Groups "Bokeh Discussion - Public" group.
> > To unsubscribe from this topic, visit https://groups.google.com/a/continuum.io/d/topic/bokeh/8Gah2axMxSI/unsubscribe\.
> > To unsubscribe from this group and all its topics, send an email to bokeh+unsubscribe@continuum.io.
> > To post to this group, send email to bokeh@continuum.io.
> > To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/CA%2BDx-4SqmER_d%3DUTHeikx_yojnYaqk21t8fhToxLNGf2JAo%3D%3DQ%40mail.gmail.com\.
> >
> > For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to bokeh+unsubscribe@continuum.io.
> > To post to this group, send email to bokeh@continuum.io.
> > To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/CALqfExZuQLXbKhe5pQNqZdj_i5FKjoPzE7hqc0s20NpUYXkjjw%40mail.gmail.com\.
> >
> > For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
> >
> >
> > --
> > You received this message because you are subscribed to a topic in the Google Groups "Bokeh Discussion - Public" group.
> > To unsubscribe from this topic, visit https://groups.google.com/a/continuum.io/d/topic/bokeh/8Gah2axMxSI/unsubscribe\.
> > To unsubscribe from this group and all its topics, send an email to bokeh+unsubscribe@continuum.io.
> > To post to this group, send email to bokeh@continuum.io.
> > To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/CA%2BDx-4Rc%2Bn7j8Hiu14bfqEKbaWQ16GkxNn_-HqQWzBRbORzZjg%40mail.gmail.com\.
> >
> > For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to bokeh+unsubscribe@continuum.io.
> > To post to this group, send email to bokeh@continuum.io.
> > To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/CALqfExboxDJuMHuo1490tZJOKp4S-wSM1H3NDc3FCONm8Tj%3DmQ%40mail.gmail.com\.
> >
> > For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
> >
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to bokeh+unsubscribe@continuum.io.
> > To post to this group, send email to bokeh@continuum.io.
> > To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/CA%2BDx-4QNCGHKecHtZMxsd4a%2B10GfzNWQdmds_wvqBFvmGuAMZA%40mail.gmail.com\.
> > For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
>
> --
> You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to bokeh+unsubscribe@continuum.io.
> To post to this group, send email to bokeh@continuum.io.
> To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/6A2A24F5-434D-4977-B921-F1B64FA400E5%40anaconda.com\.
> For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
>
>
> --
> You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to bokeh+unsubscribe@continuum.io.
> To post to this group, send email to bokeh@continuum.io.
> To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/CA%2BDx-4QUmWZR5w3XUYwjW_uMruXetF4LX0v7puG0raHgCZb1cA%40mail.gmail.com\.
> For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
--
You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bokeh+unsubscribe@continuum.io.
To post to this group, send email to bokeh@continuum.io.
To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/B9DE12E3-848E-48AD-8E0F-B197A484E21D%40anaconda.com\.
For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
--
You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bokeh+unsubscribe@continuum.io.
To post to this group, send email to bokeh@continuum.io.
To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/CA%2BDx-4ToqxOwcK6btBBzXsrifqKSmTfUo830PiGpKBWrA273Ug%40mail.gmail.com\.
For more options, visit https://groups.google.com/a/continuum.io/d/optout\.
