potential issue with 0.12.6dev5 building on windows

On Wed, May 17, 2017 at 3:39 PM, Peter Anderson mrpanderson@gmail.com wrote:

Hello,

I have cloned the master at 0.12.6dev5-5-g32eba5c0d.

When I try to build on windows using the instructions on the developer guide I get the following error.

C:\Users\xxx\Desktop\GitHub\bokeh\bokehjs>gulp build

C:\Users\xxx\Desktop\GitHub\bokeh\bokehjs\gulpfile.js:2

const {TSError} = require(“ts-node”)

  ^

SyntaxError: Unexpected token {

at exports.runInThisContext (vm.js:53:16)

at Module._compile (module.js:373:25)

at Object.Module._extensions..js (module.js:416:10)

at Module.load (module.js:343:32)

at Function.Module._load (module.js:300:12)

at Module.require (module.js:353:17)

at require (internal/module.js:12:17)

at Liftoff.handleArguments (C:\ProgramData\Anaconda3\Library\bi

s\gulp\bin\gulp.js:116:3)

at Liftoff.<anonymous> (C:\ProgramData\Anaconda3\Library\bin\no

lp\node_modules\liftoff\index.js:198:16)

at module.exports (C:\ProgramData\Anaconda3\Library\bin\node_mo

de_modules\flagged-respawn\index.js:17:3)

The build is successful when I change the following line in gulpfile.js

const {TSError} = require(“ts-node”)

to

const TSError = require(“ts-node”)

the build is successful, because there are no errors from typescript compiler, so this import doesn’t matter. The likely reason for this syntax not being supported is old version of node.js. bokehjs requires version >= 6.6.0 and < 7.0 (though 7.x may work, but there are known performance regressions).

Mateusz

I understand this is a dev build and do not want to litter github with unnecessary comments. If you think it is appropriate I will raise it there.

–

You received this message because you are subscribed to the Google Groups “Bokeh Discussion - Public” group.

To unsubscribe from this group and stop receiving emails from it, send an email to bokeh+unsubscribe@continuum.io.

To post to this group, send email to bokeh@continuum.io.

To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/258525f9-dc85-435c-8f1b-64620a703014%40continuum.io.

For more options, visit https://groups.google.com/a/continuum.io/d/optout.