Are line properties working in 0.9.3

I’m trying to use some line properties for very simple line plots, like in the “single line example” in the Getting Started section here: http://bokeh.pydata.org/en/latest/docs/quickstart.html, but even adding only line_join=‘round’ to p.line(…) in that example does not have the intended effect (or any effect whatsoever). Are these properties working only on glyphs? And if so, how can I achieve the desired effect on a line in a figure?

Thanks!

You've uncovered a small bug specifically with respect to "line_join" (you can seem almost all the other properties demonstrated working throughout the docs, but you may be the first person to need to actually use "line_join") The bug is here:

   https://github.com/bokeh/bokeh/blob/master/bokehjs/src/coffee/common/properties.coffee#L256

where

  ctx.lineCap = @join.value()

should obviously be

  ctx.lineJoin = @join.value()

We are all right in the middle of the 0.10 release process and currently pretty swamped. If you'd like to make a GitHub issue and submit a Pull Request with this fix I can confidently say it would be in the next release, and even in the first dev build release after 0.10 is out.

Thanks,

Bryan

···

On Sep 21, 2015, at 7:53 AM, [email protected] wrote:

I'm trying to use some line properties for very simple line plots, like in the "single line example" in the Getting Started section here: http://bokeh.pydata.org/en/latest/docs/quickstart.html, but even adding only line_join='round' to p.line(...) in that example does not have the intended effect (or any effect whatsoever). Are these properties working only on glyphs? And if so, how can I achieve the desired effect on a line in a figure?

Thanks!

--
You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/28569469-154e-40f8-be0d-98e911e69b4b%40continuum.io.
For more options, visit https://groups.google.com/a/continuum.io/d/optout.

I went ahead and made the GH issue:

  https://github.com/bokeh/bokeh/issues/2894

So, if you'd like to contribute the one-line PR to fix this, that would be great!

Bryan

···

On Sep 21, 2015, at 8:38 AM, Bryan Van de Ven <[email protected]> wrote:

You've uncovered a small bug specifically with respect to "line_join" (you can seem almost all the other properties demonstrated working throughout the docs, but you may be the first person to need to actually use "line_join") The bug is here:

   https://github.com/bokeh/bokeh/blob/master/bokehjs/src/coffee/common/properties.coffee#L256

where

  ctx.lineCap = @join.value()

should obviously be

  ctx.lineJoin = @join.value()

We are all right in the middle of the 0.10 release process and currently pretty swamped. If you'd like to make a GitHub issue and submit a Pull Request with this fix I can confidently say it would be in the next release, and even in the first dev build release after 0.10 is out.

Thanks,

Bryan

On Sep 21, 2015, at 7:53 AM, [email protected] wrote:

I'm trying to use some line properties for very simple line plots, like in the "single line example" in the Getting Started section here: http://bokeh.pydata.org/en/latest/docs/quickstart.html, but even adding only line_join='round' to p.line(...) in that example does not have the intended effect (or any effect whatsoever). Are these properties working only on glyphs? And if so, how can I achieve the desired effect on a line in a figure?

Thanks!

--
You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/28569469-154e-40f8-be0d-98e911e69b4b%40continuum.io.
For more options, visit https://groups.google.com/a/continuum.io/d/optout.

Done.

In fact, I think a “round” line join value would make a much more useful default in most cases.

Thanks!

Bryan Van de ven:

···

I went ahead and made the GH issue:

    [https://github.com/bokeh/bokeh/issues/2894](https://github.com/bokeh/bokeh/issues/2894)

So, if you’d like to contribute the one-line PR to fix this, that would be great!

Bryan

Thanks!

I can't say I have any strong opinions about what the best default is. Maybe ping the GH issue with this question we can see what other people think. Do you know what the behviour of other libraries is in this regard?

Thanks again,

Bryan

···

On Sep 23, 2015, at 3:09 AM, [email protected] wrote:

Done.

In fact, I think a "round" line join value would make a much more useful default in most cases.

Thanks!

Bryan Van de ven:
I went ahead and made the GH issue:

        https://github.com/bokeh/bokeh/issues/2894

So, if you'd like to contribute the one-line PR to fix this, that would be great!

Bryan

--
You received this message because you are subscribed to the Google Groups "Bokeh Discussion - Public" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/a/continuum.io/d/msgid/bokeh/53beedd8-8cb9-4c96-b426-73a65ff8d678%40continuum.io.
For more options, visit https://groups.google.com/a/continuum.io/d/optout.